Issue 1986012: Only kill the dev server when it is started by image_to_live process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1986012: Only kill the dev server when it is started by image_to_live process. (Closed)

Created:
10 years, 7 months ago by ericli

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Only kill the dev server when it is started by image_to_live process.

Patch Set 1 #

Patch Set 2 : patch 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/scripts/image_to_live.sh	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 7 months ago (2010-05-15 01:07:24 UTC) #2

LGTM

On Wed, May 12, 2010 at 5:29 PM,  <ericli@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Only kill the dev server when it is started by image_to_live process.
>
> Please review this at http://codereview.chromium.org/1986012/show
>
> SVN Base: ssh://git@chromiumos-git/chromeos
>
> Affected files:
>  M src/scripts/image_to_live.sh
>
>
> Index: src/scripts/image_to_live.sh
> diff --git a/src/scripts/image_to_live.sh b/src/scripts/image_to_live.sh
> index
>
c75e3684acbcf75c0a755b6157b22631feb102b5..594437c9a9bae6eca1fb9c0b83ab0e47766342d7
> 100755
> --- a/src/scripts/image_to_live.sh
> +++ b/src/scripts/image_to_live.sh
> @@ -32,7 +32,9 @@ function kill_all_devservers {
>
>  function cleanup {
>   echo "Killing dev server."
> -  kill_all_devservers
> +  if [ -z "${FLAGS_update_url}" ]; then
> +    kill_all_devservers
> +  fi
>   cleanup_remote_access
>   rm -rf "${TMP}"
>  }
>
>
>

Expand Messages | Collapse Messages