Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1986005: Add more exceptions to check_deps to allow usage of icedtea. (Closed)

Created:
10 years, 7 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

Add more exceptions to check_deps to allow usage of icedtea. BUG=none TEST=Ran test_image on image with icedtea

Patch Set 1 #

Total comments: 2

Patch Set 2 : Look in /usr/local #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M src/scripts/check_deps View 1 2 chunks +25 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davidjames
10 years, 7 months ago (2010-05-10 23:57:08 UTC) #1
Zhenyao Mo
http://codereview.chromium.org/1986005/diff/1/2 File src/scripts/check_deps (right): http://codereview.chromium.org/1986005/diff/1/2#newcode36 src/scripts/check_deps:36: "%s/usr/lib/icedtea6/jre/lib/i386/client" % root, It should be %ROOT%/usr/local/lib/icedtea6 ... instead.
10 years, 7 months ago (2010-05-11 00:02:44 UTC) #2
davidjames
zmo, please test this, as I don't have a copy of your icedtea changes http://codereview.chromium.org/1986005/diff/1/2 ...
10 years, 7 months ago (2010-05-11 00:25:40 UTC) #3
Zhenyao Mo
10 years, 7 months ago (2010-05-11 01:10:19 UTC) #4 
LGTM

On 2010/05/11 00:25:40, davidjames wrote:
> zmo, please test this, as I don't have a copy of your icedtea changes
> 
> http://codereview.chromium.org/1986005/diff/1/2
> File src/scripts/check_deps (right):
> 
> http://codereview.chromium.org/1986005/diff/1/2#newcode36
> src/scripts/check_deps:36: "%s/usr/lib/icedtea6/jre/lib/i386/client" % root,
> On 2010/05/11 00:02:44, Zhenyao Mo wrote:
> > It should be %ROOT%/usr/local/lib/icedtea6 ... instead.
> 
> Done.

Powered by Google App Engine
This is Rietveld 408576698