Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 198039: Aesthetic changes to the proxy configuration log format.... (Closed)

Created:
11 years, 3 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, willchan no longer on Chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Aesthetic changes to the proxy configuration log format. Also in this change, I stop brodacasting the proxy settings changes to LOG(INFO) --- This is because navigating to "view-net-internal:proxyservice.config" offers a better solution, so no point polluting the log file. Note that the format change is intended to make the string more succint and human readable. For example, here is a before and after comparison: ------------ New version: ------------ Automatic settings: Auto-detect: No Custom PAC script: [None] Manual settings: Proxy server: [None] Bypass list: [None] Bypass local names: No ------------ Old version: ------------ { auto_detect: 0 pac_url: proxy_rules: { type: TYPE_NO_RULES single_proxy: proxy_for_http: proxy_for_https: proxy_for_ftp: socks_proxy: } proxy_bypass_local_names: 0 proxy_bypass_list: id: 1 } BUG=http://crbug.com/14478 TEST=ProxyConfigTest.ToString Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25584

Patch Set 1 #

Patch Set 2 : Split up a long line #

Patch Set 3 : Split up another long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -39 lines) Patch
M net/proxy/proxy_config.cc View 1 2 2 chunks +45 lines, -13 lines 0 comments Download
M net/proxy/proxy_config_unittest.cc View 1 2 15 chunks +146 lines, -24 lines 0 comments Download
M net/proxy/proxy_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
darin (slow to review)
11 years, 3 months ago (2009-09-05 14:17:49 UTC) #1
OK, LGTM

Powered by Google App Engine
This is Rietveld 408576698