Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 198038: Add 3 more flavors of the try chrome toast... (Closed)

Created:
11 years, 3 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Add 3 more flavors of the try chrome toast - Different strings, pretty much the same deal. - One case removes the radio buttons. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25769

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -24 lines) Patch
M chrome/browser/browser_main.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/first_run.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/first_run_win.cc View 1 7 chunks +72 lines, -20 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
cpu_(ooo_6.6-7.5)
I believe you are the mastermind of the dialogs so it seems fitting to suffer ...
11 years, 3 months ago (2009-09-05 01:53:21 UTC) #1
Glen Murphy
LGTM, just spelling. I'm assuming the version_ and results are recorded elsewhere. http://codereview.chromium.org/198038/diff/1/2 File chrome/browser/first_run_win.cc ...
11 years, 3 months ago (2009-09-08 22:35:15 UTC) #2
cpu_(ooo_6.6-7.5)
11 years, 3 months ago (2009-09-09 01:06:21 UTC) #3
going in. thanks

http://codereview.chromium.org/198038/diff/1/2
File chrome/browser/first_run_win.cc (right):

http://codereview.chromium.org/198038/diff/1/2#newcode847
Line 847: // The usser pressed cancel or the [x] button.
On 2009/09/08 22:35:15, Glen Murphy wrote:
> Spelling: 'user'

Done.

Powered by Google App Engine
This is Rietveld 408576698