Issue 198036: Fixes bug in views on gtk where we wouldn't necessarily paint...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 198036: Fixes bug in views on gtk where we wouldn't necessarily paint... (Closed)

Created:
11 years, 3 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes bug in views on gtk where we wouldn't necessarily paint correctly on an expose. This happened if between the time we told Gtk we needed to paint and the time we got the expose event more paints were scheduled. In this case, because we were double buffered, GTK would clip to the original region we scheduled the paint for. The fix is to turn off double buffering as we're double buffering ourself. BUG=none TEST=none

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	views/widget/widget_gtk.cc	View		5 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages