Issue 19765: Fix PopupMenuChromium to hide itself before calling valueChanged. This bette...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19765: Fix PopupMenuChromium to hide itself before calling valueChanged. This bette... (Closed)

Created:
11 years, 10 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix PopupMenuChromium to hide itself before calling valueChanged. This better matches the behavior of the other ports and also fixes bug 3514. BUG=3514 R=ojan

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -29 lines)			Patch
	M	third_party/WebKit/WebCore/platform/chromium/PopupMenuChromium.cpp	View	1 2	7 chunks	+20 lines, -29 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

Please pre-flight this CL. If it looks good, I'll submit it to https://bugs.webkit.org/show_bug.cgi?id=23696 Thanks!

11 years, 10 months ago (2009-02-02 22:01:04 UTC) #1

ojan

11 years, 10 months ago (2009-02-02 23:29:51 UTC) #2

LGTM

On 2009/02/02 22:01:04, darin wrote:
> Please pre-flight this CL.  If it looks good, I'll submit it to
> https://bugs.webkit.org/show_bug.cgi?id=23696
> 
> Thanks!

Expand Messages | Collapse Messages