Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 19751: Added regexp tests from PCRE. (Closed)

Created:
11 years, 10 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added regexp tests from PCRE. Committed: http://code.google.com/p/v8/source/detail?r=1207

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6609 lines, -1 line) Patch
M LICENSE View 2 chunks +6 lines, -1 line 0 comments Download
M test/mjsunit/regexp-capture.js View 1 chunk +5 lines, -0 lines 0 comments Download
test/mjsunit/regexp-pcre.js View 1 chunk +6598 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
11 years, 10 months ago (2009-02-02 13:52:25 UTC) #1
Christian Plesner Hansen
This code review is broken; file is too large.
11 years, 10 months ago (2009-02-02 13:59:36 UTC) #2
Erik Corry
11 years, 10 months ago (2009-02-02 14:01:28 UTC) #3
Christian Plesner Hansen
11 years, 10 months ago (2009-02-02 14:13:02 UTC) #4
Lgtm.  I would add a comment that explains that the fact that we have tests
including stuff like \p{SomeObscureCharacter} doesn't mean that we support it.

Powered by Google App Engine
This is Rietveld 408576698