Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: net/disk_cache/disk_cache.h

Issue 19747: URLRequestContext and disk cache for media files (Closed)
Patch Set: signed and unsigned... Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/testing_profile.h ('k') | net/disk_cache/entry_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/disk_cache.h
diff --git a/net/disk_cache/disk_cache.h b/net/disk_cache/disk_cache.h
index 59d2ad25a740f1232adb0ab22bacf25d49072d01..7d6e41a3ce349fd24cd70fff56e4d457600519cc 100644
--- a/net/disk_cache/disk_cache.h
+++ b/net/disk_cache/disk_cache.h
@@ -12,6 +12,7 @@
#include <vector>
#include "base/basictypes.h"
+#include "base/platform_file.h"
#include "base/time.h"
#include "net/base/completion_callback.h"
@@ -153,6 +154,29 @@ class Entry {
net::CompletionCallback* completion_callback,
bool truncate) = 0;
+ // Prepares a target stream as an external file, returns a corresponding
+ // base::PlatformFile if successful, returns base::kInvalidPlatformFileValue
+ // if fails. If this call returns a valid base::PlatformFile value (i.e.
+ // not base::kInvalidPlatformFileValue), there is no guarantee that the file
+ // is truncated. Implementor can always return base::kInvalidPlatformFileValue
+ // if external file is not available in that particular implementation.
+ // Caller should never close the file handle returned by this method, since
+ // the handle should be managed by the implementor of this class. Caller
+ // should never save the handle for future use.
+ // With a stream prepared as an external file, the stream would always be
+ // kept in an external file since creation, even if the stream has 0 bytes.
+ // So we need to be cautious about using this option for preparing a stream or
+ // we will end up having a lot of empty cache files. Calling this method also
+ // means that all data written to the stream will always be written to file
+ // directly *without* buffering.
+ virtual base::PlatformFile UseExternalFile(int index) = 0;
+
+ // Returns a read file handle for the cache stream referenced by |index|.
+ // Caller should never close the handle returned by this method and should
+ // not save it for future use. The lifetime of the base::PlatformFile handle
+ // is managed by the implementor of this class.
+ virtual base::PlatformFile GetPlatformFile(int index) = 0;
+
protected:
virtual ~Entry() {}
};
« no previous file with comments | « chrome/test/testing_profile.h ('k') | net/disk_cache/entry_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698