Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: src/codegen-ia32.cc

Issue 19745: Fix for off-by-one when initializing a constant or function... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/codegen-arm.cc ('k') | test/mjsunit/regress/regress-220.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-ia32.cc
===================================================================
--- src/codegen-ia32.cc (revision 1198)
+++ src/codegen-ia32.cc (working copy)
@@ -1431,15 +1431,13 @@
}
if (val != NULL) {
- // Set initial value.
- Reference target(this, node->proxy());
- ASSERT(target.is_slot());
- Load(val);
- target.SetValue(NOT_CONST_INIT);
- // Get rid of the assigned value (declarations are statements). It's
- // safe to pop the value lying on top of the reference before unloading
- // the reference itself (which preserves the top of stack) because we
- // know that it is a zero-sized reference.
+ {
+ // Set initial value.
+ Reference target(this, node->proxy());
+ Load(val);
+ target.SetValue(NOT_CONST_INIT);
+ }
+ // Get rid of the assigned value (declarations are statements).
frame_->Pop();
}
}
« no previous file with comments | « src/codegen-arm.cc ('k') | test/mjsunit/regress/regress-220.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698