Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 19733: Make sure that Clipboard operations that require dispatching... (Closed)

Created:
11 years, 10 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make sure that Clipboard operations that require dispatching of windows messages are performed on the UI thread. SetClipboardData requires the clipboard to be open with a handle to a window that will be notified when the contents are going to change again. If Windows messages are not processed, any other app writing to the clipboard will be locked while we acknowledge their request (by processing the message). The IO thread doesn't pump windows messages anymore so write clipboard operations cannot be performed from that thread and have to be posted to another thread. BUG=5823 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9003

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -19 lines) Patch
M base/clipboard.h View 2 chunks +8 lines, -0 lines 1 comment Download
M base/clipboard_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M base/clipboard_win.cc View 10 chunks +51 lines, -17 lines 0 comments Download
M base/file_util_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resource_message_filter.cc View 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
rvargas (doing something else)
11 years, 10 months ago (2009-01-30 23:44:27 UTC) #1
jam
11 years, 10 months ago (2009-01-31 00:24:47 UTC) #2
lgtm

http://codereview.chromium.org/19733/diff/1/4
File base/clipboard.h (right):

http://codereview.chromium.org/19733/diff/1/4#newcode190
Line 190: // true if we can create a window.
nit: please capitalize True.

Powered by Google App Engine
This is Rietveld 408576698