Issue 19721: Random bits of de-Winification for WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19721: Random bits of de-Winification for WebContents. (Closed)

Created:
11 years, 10 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Random bits of de-Winification for WebContents. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8987

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -28 lines)			Patch
M	chrome/browser/plugin_installer.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/plugin_service.h	View	1	4 chunks	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/printing/print_job.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/search_engines/template_url_fetcher.h	View	1	5 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/shell_dialogs.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_win.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 10 months ago (2009-01-30 20:45:19 UTC) #2

LGTM

http://codereview.chromium.org/19721/diff/1/8
File chrome/browser/search_engines/template_url_fetcher.h (right):

http://codereview.chromium.org/19721/diff/1/8#newcode86
Line 86: gfx::NativeView parent_window_;
Nit: Did you mean to lose the const?

Expand Messages | Collapse Messages