Issue 1972001: graphics_WindowManagerGraphicsCapture test taking screenshots and comparing them to reference images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1972001: graphics_WindowManagerGraphicsCapture test taking screenshots and comparing them to reference images (Closed)

Created:
10 years, 7 months ago by scheib

Modified:
9 years, 7 months ago

Reviewers:
Alexey Marinichev, piman

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
ssh://git@chromiumos-git/autotest.git

Visibility:
Public.

Description

graphics_WindowManagerGraphicsCapture test taking screenshots and comparing them to reference images. BUG=2054 TEST=graphics_WindowManagerGraphicsCapture

Patch Set 2 : comment fixes #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -16 lines)			Patch
M	client/deps/glbench/src/main.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	client/deps/glbench/src/windowmanagertest.cc	View	1	2 chunks	+62 lines, -12 lines	0 comments	Download
M	client/site_tests/graphics_WindowManagerGraphicsCapture/graphics_WindowManagerGraphicsCapture.py	View		1 chunk	+34 lines, -6 lines	0 comments	Download
A	client/site_tests/graphics_WindowManagerGraphicsCapture/screenshot1_reference	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	client/site_tests/graphics_WindowManagerGraphicsCapture/screenshot2_reference	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheib

graphics_WindowManagerGraphicsCapture test now working, build system in place for imagemagick and perceptualdiff. Tested on two ...

10 years, 7 months ago (2010-05-05 01:09:37 UTC) #1

piman

LGTM with 1 comment http://codereview.chromium.org/1972001/diff/1/3 File client/deps/glbench/src/windowmanagertest.cc (right): http://codereview.chromium.org/1972001/diff/1/3#newcode68 client/deps/glbench/src/windowmanagertest.cc:68: // times a second. Comment ...

10 years, 7 months ago (2010-05-05 16:45:45 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 1972001: graphics_WindowManagerGraphicsCapture test taking screenshots and comparing them to reference images (Closed)

Description

Patch Set 1 #

Patch Set 2 : comment fixes #

Messages