Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 197054: Don't send the channel-disconnect message if the recipient is in the process (Closed)

Created:
11 years, 3 months ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
rafaelw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Don't send the channel-disconnect message if the recipient is in the process of closing. This is an attempt to fix a crash bug. TEST=no BUG=21201 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25767

Patch Set 1 #

Total comments: 1

Patch Set 2 : updated comment #

Patch Set 3 : raf's rewording is better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M chrome/browser/extensions/extension_message_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 2 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Matt Perry
11 years, 3 months ago (2009-09-09 00:55:39 UTC) #1
rafaelw
lgtm http://codereview.chromium.org/197054/diff/1/2 File chrome/browser/extensions/extension_message_service.cc (right): http://codereview.chromium.org/197054/diff/1/2#newcode461 Line 461: bool notify_other_port = I think this variable ...
11 years, 3 months ago (2009-09-09 18:03:55 UTC) #2
rafaelw
11 years, 3 months ago (2009-09-09 18:04:37 UTC) #3
sorry. changed my mine. the variable name is fine. my only request is the
comment.

Powered by Google App Engine
This is Rietveld 408576698