Add a unit test for FTP directory listing.

net/url_request/url_request_unittest.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_unittest.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
@@ skipping 1931 matching lines @@
   static void TearDownTestCase() {
     server_ = NULL;
   }
 
   static scoped_refptr<FTPTestServer> server_;
 };
 
 // static
 scoped_refptr<FTPTestServer> URLRequestTestFTP::server_;
 
+TEST_F(URLRequestTestFTP, FTPDirectoryListing) {
+  ASSERT_TRUE(NULL != server_.get());
+  TestDelegate d;
+  {
+    TestURLRequest r(server_->TestServerPage("/"), &d);
+    r.Start();
+    EXPECT_TRUE(r.is_pending());
+
+    MessageLoop::current()->Run();
+
+    EXPECT_FALSE(r.is_pending());
+    EXPECT_EQ(1, d.response_started_count());
+    EXPECT_FALSE(d.received_data_before_response());
+    EXPECT_LT(0, d.bytes_received());

[eroman, 2009/09/08 23:39:41]

this seems a bit odd to use LT.

Can this be a direct comparison instead like:
  EXPECT_EQ(-1, d.bytes_received());

Also, would be nice if we can verify something which is listing specific.

+  }
+}
+
 TEST_F(URLRequestTestFTP, FTPGetTestAnonymous) {
   ASSERT_TRUE(NULL != server_.get());
   FilePath app_path;
   PathService::Get(base::DIR_SOURCE_ROOT, &app_path);
   app_path = app_path.AppendASCII("LICENSE");
   TestDelegate d;
   {
     TestURLRequest r(server_->TestServerPage("/LICENSE"), &d);
     r.Start();
     EXPECT_TRUE(r.is_pending());
@@ skipping 130 matching lines @@
 
     int64 file_size = 0;
     file_util::GetFileSize(app_path, &file_size);
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d.response_started_count());
     EXPECT_FALSE(d.received_data_before_response());
     EXPECT_EQ(d.bytes_received(), static_cast<int>(file_size));
   }
 }