Issue 197045: Implement a way to run each interactive UI test isolated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197045: Implement a way to run each interactive UI test isolated (Closed)

Created:
11 years, 3 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This CL makes a more generic browser test launcher and a DLL of the interactive UI tests, so the interactive UI tests can be run isolated. BUG=None TEST=Run the the interactive ui tests with the new launcher: test_launcher --lib=interactive_ui_tests_dll Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25863

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -513 lines)			Patch
M	chrome/chrome.gyp	View	1 2 3	6 chunks	+158 lines, -9 lines	0 comments	Download
D	chrome/test/browser/browser_test_launcher_in_proc.cc	View	1 2 3	1 chunk	+0 lines, -124 lines	0 comments	Download
D	chrome/test/browser/browser_test_launcher_out_of_proc.cc	View	1 2 3	1 chunk	+0 lines, -88 lines	0 comments	Download
D	chrome/test/browser/browser_test_runner.h	View	1 2 3	1 chunk	+0 lines, -51 lines	0 comments	Download
D	chrome/test/browser/browser_test_runner.cc	View	1 2 3	1 chunk	+0 lines, -133 lines	0 comments	Download
D	chrome/test/browser/run_all_unittests.cc	View	1 2 3	1 chunk	+0 lines, -46 lines	0 comments	Download
A +	chrome/test/test_launcher/in_proc_test_runner.cc	View	1 2 3 4	4 chunks	+34 lines, -23 lines	0 comments	Download
A +	chrome/test/test_launcher/out_of_proc_test_runner.cc	View		3 chunks	+13 lines, -15 lines	0 comments	Download
A +	chrome/test/test_launcher/run_all_unittests.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/test_launcher/test_runner.h	View	1 2	2 chunks	+16 lines, -15 lines	0 comments	Download
A +	chrome/test/test_launcher/test_runner.cc	View		4 chunks	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

11 years, 3 months ago (2009-09-08 20:32:25 UTC) #2

Some nits. After fixing them, LGTM. Thanks!

http://codereview.chromium.org/197045/diff/4002/4009
File chrome/test/test_launcher/in_proc_test_runner.cc (right):

http://codereview.chromium.org/197045/diff/4002/4009#newcode31
Line 31: InProcTestRunner(const std::wstring& lib_name)
nit: This ctor should be explicit.

http://codereview.chromium.org/197045/diff/4002/4009#newcode98
Line 98: InProcTestRunnerFactory(const std::wstring& lib_name) :
lib_name_(lib_name) {
nit: This has a 3-space indent and should be explicit.

http://codereview.chromium.org/197045/diff/4002/4012
File chrome/test/test_launcher/test_runner.h (right):

http://codereview.chromium.org/197045/diff/4002/4012#newcode46
Line 46: public:
Please add a virtual dtor here. Lack of it always bites later.

Expand Messages | Collapse Messages