Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6209)

Unified Diff: chrome/common/extensions/url_pattern_unittest.cc

Issue 19704: Introduce UrlPattern. (Closed)
Patch Set: more feedback Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/url_pattern.cc ('k') | chrome/test/unit/unit_tests.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/url_pattern_unittest.cc
diff --git a/chrome/common/extensions/url_pattern_unittest.cc b/chrome/common/extensions/url_pattern_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b53fc07549637ec595444c4df4daaf0970cce13f
--- /dev/null
+++ b/chrome/common/extensions/url_pattern_unittest.cc
@@ -0,0 +1,132 @@
+// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/extensions/url_pattern.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+// See url_pattern.h for examples of valid and invalid patterns.
+
+TEST(URLPatternTest, ParseInvalid) {
+ const char* kInvalidPatterns[] = {
+ "http", // no scheme
+ "http://", // no path separator
+ "http://foo", // no path separator
+ "http://*foo/bar", // not allowed as substring of host component
+ "http://foo.*.bar/baz", // must be first component
+ "http:/bar", // scheme separator not found
+ "foo://*", // invalid scheme
+ };
+
+ for (size_t i = 0; i < arraysize(kInvalidPatterns); ++i) {
+ URLPattern pattern;
+ EXPECT_FALSE(pattern.Parse(kInvalidPatterns[i]));
+ }
+};
+
+// all pages for a given scheme
+TEST(URLPatternTest, Match1) {
+ URLPattern pattern;
+ EXPECT_TRUE(pattern.Parse("http://*/*"));
+ EXPECT_EQ("http", pattern.scheme());
+ EXPECT_EQ("", pattern.host());
+ EXPECT_TRUE(pattern.match_subdomains());
+ EXPECT_EQ("/*", pattern.path());
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("http://google.com")));
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("http://yahoo.com")));
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("http://google.com/foo")));
+ EXPECT_FALSE(pattern.MatchesUrl(GURL("https://google.com")));
+}
+
+// all domains
+TEST(URLPatternTest, Match2) {
+ URLPattern pattern;
+ EXPECT_TRUE(pattern.Parse("https://*/foo*"));
+ EXPECT_EQ("https", pattern.scheme());
+ EXPECT_EQ("", pattern.host());
+ EXPECT_TRUE(pattern.match_subdomains());
+ EXPECT_EQ("/foo*", pattern.path());
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("https://www.google.com/foo")));
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("https://www.google.com/foobar")));
+ EXPECT_FALSE(pattern.MatchesUrl(GURL("http://www.google.com/foo")));
+ EXPECT_FALSE(pattern.MatchesUrl(GURL("https://www.google.com/")));
+}
+
+// subdomains
+TEST(URLPatternTest, Match3) {
+ URLPattern pattern;
+ EXPECT_TRUE(pattern.Parse("http://*.google.com/foo*bar"));
+ EXPECT_EQ("http", pattern.scheme());
+ EXPECT_EQ("google.com", pattern.host());
+ EXPECT_TRUE(pattern.match_subdomains());
+ EXPECT_EQ("/foo*bar", pattern.path());
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("http://google.com/foobar")));
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("http://www.google.com/foo?bar")));
+ EXPECT_TRUE(pattern.MatchesUrl(
+ GURL("http://monkey.images.google.com/foooobar")));
+ EXPECT_FALSE(pattern.MatchesUrl(GURL("http://yahoo.com/foobar")));
+}
+
+// odd schemes and normalization
+TEST(URLPatternTest, Match4) {
+ URLPattern pattern;
+ EXPECT_TRUE(pattern.Parse("chrome-ui://thinger/*"));
+ EXPECT_EQ("chrome-ui", pattern.scheme());
+ EXPECT_EQ("thinger", pattern.host());
+ EXPECT_FALSE(pattern.match_subdomains());
+ EXPECT_EQ("/*", pattern.path());
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("chrome-ui://thinger/foobar")));
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("CHROME-UI://thinger/")));
+ EXPECT_FALSE(pattern.MatchesUrl(GURL("http://thinger/")));
+}
+
+// glob escaping
+TEST(URLPatternTest, Match5) {
+ URLPattern pattern;
+ EXPECT_TRUE(pattern.Parse("file:///foo?bar\\*baz"));
+ EXPECT_EQ("file", pattern.scheme());
+ EXPECT_EQ("", pattern.host());
+ EXPECT_FALSE(pattern.match_subdomains());
+ EXPECT_EQ("/foo?bar\\*baz", pattern.path());
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("file:///foo?bar\\hellobaz")));
+ EXPECT_FALSE(pattern.MatchesUrl(GURL("file:///fooXbar\\hellobaz")));
+}
+
+// ip addresses
+TEST(URLPatternTest, Match6) {
+ URLPattern pattern;
+ EXPECT_TRUE(pattern.Parse("http://127.0.0.1/*"));
+ EXPECT_EQ("http", pattern.scheme());
+ EXPECT_EQ("127.0.0.1", pattern.host());
+ EXPECT_FALSE(pattern.match_subdomains());
+ EXPECT_EQ("/*", pattern.path());
+ EXPECT_TRUE(pattern.MatchesUrl(GURL("http://127.0.0.1")));
+}
+
+// subdomain matching with ip addresses
+TEST(URLPatternTest, Match7) {
+ URLPattern pattern;
+ EXPECT_TRUE(pattern.Parse("http://*.0.0.1/*")); // allowed, but useless
+ EXPECT_EQ("http", pattern.scheme());
+ EXPECT_EQ("0.0.1", pattern.host());
+ EXPECT_TRUE(pattern.match_subdomains());
+ EXPECT_EQ("/*", pattern.path());
+ // Subdomain matching is never done if the argument has an IP address host.
+ EXPECT_FALSE(pattern.MatchesUrl(GURL("http://127.0.0.1")));
+};
+
+// unicode
+TEST(URLPatternTest, Match8) {
+ URLPattern pattern;
+ // The below is the ASCII encoding of the following URL:
+ // http://*.\xe1\x80\xbf/a\xc2\x81\xe1*
+ EXPECT_TRUE(pattern.Parse("http://*.xn--gkd/a%C2%81%E1*"));
+ EXPECT_EQ("http", pattern.scheme());
+ EXPECT_EQ("xn--gkd", pattern.host());
+ EXPECT_TRUE(pattern.match_subdomains());
+ EXPECT_EQ("/a%C2%81%E1*", pattern.path());
+ EXPECT_TRUE(pattern.MatchesUrl(
+ GURL("http://abc.\xe1\x80\xbf/a\xc2\x81\xe1xyz")));
+ EXPECT_TRUE(pattern.MatchesUrl(
+ GURL("http://\xe1\x80\xbf/a\xc2\x81\xe1\xe1")));
Matt Perry 2009/01/31 01:29:14 interesting. what does pattern.MatchesUrl(GURL("h
+};
« no previous file with comments | « chrome/common/extensions/url_pattern.cc ('k') | chrome/test/unit/unit_tests.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698