Prevent constrained popup windows from trying to become real...

chrome/browser/web_contents.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_contents.h"
 
 #include "base/command_line.h"
 #include "base/file_version_info.h"
 #include "chrome/app/locales/locale_settings.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
@@ skipping 1884 matching lines @@
     select_file_dialog_ = SelectFileDialog::Create(this);
   select_file_dialog_->SelectFile(SelectFileDialog::SELECT_OPEN_FILE, L"",
                                   default_file, toplevel_hwnd, NULL);
 }
 
 void WebContents::RunJavaScriptMessage(
     const std::wstring& message,
     const std::wstring& default_prompt,
     const int flags,
     IPC::Message* reply_msg) {
-  if (!suppress_javascript_messages_) {
+  // Suppress javascript messages when requested and when inside a constrained
+  // popup window (because that activates them and breaks them out of the
+  // constrained window jail).
+  bool suppress_this_message = suppress_javascript_messages_;
+  if (delegate())
+    suppress_this_message |= delegate()->IsPopup(this);
+
+  if (!suppress_this_message) {
     TimeDelta time_since_last_message(
         TimeTicks::Now() - last_javascript_message_dismissal_);
     bool show_suppress_checkbox = false;
     // Show a checkbox offering to suppress further messages if this message is
     // being displayed within kJavascriptMessageExpectedDelay of the last one.
     if (time_since_last_message <
         TimeDelta::FromMilliseconds(kJavascriptMessageExpectedDelay))
       show_suppress_checkbox = true;
 
     JavascriptMessageBoxHandler::RunJavascriptMessageBox(this,
@@ skipping 666 matching lines @@
 }
 
 BOOL WebContents::EnumPluginWindowsCallback(HWND window, LPARAM) {
   if (WebPluginDelegateImpl::IsPluginDelegateWindow(window)) {
     ::ShowWindow(window, SW_HIDE);
     SetParent(window, NULL);
   }
 
   return TRUE;
 }
-