Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6682)

Unified Diff: chrome/browser/gtk/options/fonts_page_gtk.cc

Issue 1969006: Fix 18949 on GTK ("Options" window does not fit a small display). (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: Update based on evan's comments of patch set 4 and sync with trunk Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/options/fonts_page_gtk.cc
diff --git a/chrome/browser/gtk/options/fonts_page_gtk.cc b/chrome/browser/gtk/options/fonts_page_gtk.cc
index 9e73e3e89d0915720021bea2f68690319a9104b8..96c918e7dee0dc69595c26aba5ea1136dad382fa 100644
--- a/chrome/browser/gtk/options/fonts_page_gtk.cc
+++ b/chrome/browser/gtk/options/fonts_page_gtk.cc
@@ -43,8 +43,8 @@ FontsPageGtk::~FontsPageGtk() {
}
void FontsPageGtk::Init() {
- OptionsLayoutBuilderGtk options_builder;
-
+ scoped_ptr<OptionsLayoutBuilderGtk>
+ options_builder(OptionsLayoutBuilderGtk::Create());
serif_font_button_ = gtk_font_button_new();
gtk_font_button_set_use_font(GTK_FONT_BUTTON(serif_font_button_), TRUE);
gtk_font_button_set_use_size(GTK_FONT_BUTTON(serif_font_button_), TRUE);
@@ -75,7 +75,7 @@ void FontsPageGtk::Init() {
fixed_font_button_,
NULL);
- options_builder.AddOptionGroup(l10n_util::GetStringUTF8(
+ options_builder->AddOptionGroup(l10n_util::GetStringUTF8(
IDS_FONT_LANGUAGE_SETTING_FONT_SUB_DIALOG_FONT_TITLE),
font_controls, false);
@@ -86,11 +86,11 @@ void FontsPageGtk::Init() {
encoding_group_description.c_str(),
default_encoding_combobox_,
NULL);
- options_builder.AddOptionGroup(l10n_util::GetStringUTF8(
+ options_builder->AddOptionGroup(l10n_util::GetStringUTF8(
IDS_FONT_LANGUAGE_SETTING_FONT_SUB_DIALOG_ENCODING_TITLE),
encoding_controls, false);
- page_ = options_builder.get_page_widget();
+ page_ = options_builder->get_page_widget();
serif_name_.Init(prefs::kWebKitSerifFontFamily, profile()->GetPrefs(), this);
sans_serif_name_.Init(prefs::kWebKitSansSerifFontFamily,
« no previous file with comments | « chrome/browser/gtk/options/cookie_filter_page_gtk.cc ('k') | chrome/browser/gtk/options/general_page_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698