Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/browser/gtk/options/advanced_contents_gtk.cc

Issue 1969006: Fix 18949 on GTK ("Options" window does not fit a small display). (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: Update based on evan's comments of patch set 4 and sync with trunk Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/options/content_filter_page_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/options/advanced_contents_gtk.cc
diff --git a/chrome/browser/gtk/options/advanced_contents_gtk.cc b/chrome/browser/gtk/options/advanced_contents_gtk.cc
index b1257d6b28942312f498efeea804202ecb62a8b3..5ed339dbf83c7ff7b946f8dd95ffccb5c108e868 100644
--- a/chrome/browser/gtk/options/advanced_contents_gtk.cc
+++ b/chrome/browser/gtk/options/advanced_contents_gtk.cc
@@ -1193,37 +1193,38 @@ AdvancedContentsGtk::~AdvancedContentsGtk() {
}
void AdvancedContentsGtk::Init() {
- OptionsLayoutBuilderGtk options_builder;
+ scoped_ptr<OptionsLayoutBuilderGtk>
+ options_builder(OptionsLayoutBuilderGtk::Create());
privacy_section_.reset(new PrivacySection(profile_));
- options_builder.AddOptionGroup(
+ options_builder->AddOptionGroup(
l10n_util::GetStringUTF8(IDS_OPTIONS_ADVANCED_SECTION_TITLE_PRIVACY),
privacy_section_->get_page_widget(), false);
network_section_.reset(new NetworkSection(profile_));
- options_builder.AddOptionGroup(
+ options_builder->AddOptionGroup(
l10n_util::GetStringUTF8(IDS_OPTIONS_ADVANCED_SECTION_TITLE_NETWORK),
network_section_->get_page_widget(), false);
translate_section_.reset(new TranslateSection(profile_));
- options_builder.AddOptionGroup(
+ options_builder->AddOptionGroup(
l10n_util::GetStringUTF8(IDS_OPTIONS_ADVANCED_SECTION_TITLE_TRANSLATE),
translate_section_->get_page_widget(), false);
download_section_.reset(new DownloadSection(profile_));
- options_builder.AddOptionGroup(
+ options_builder->AddOptionGroup(
l10n_util::GetStringUTF8(IDS_OPTIONS_DOWNLOADLOCATION_GROUP_NAME),
download_section_->get_page_widget(), false);
web_content_section_.reset(new WebContentSection(profile_));
- options_builder.AddOptionGroup(
+ options_builder->AddOptionGroup(
l10n_util::GetStringUTF8(IDS_OPTIONS_ADVANCED_SECTION_TITLE_CONTENT),
web_content_section_->get_page_widget(), false);
security_section_.reset(new SecuritySection(profile_));
- options_builder.AddOptionGroup(
+ options_builder->AddOptionGroup(
l10n_util::GetStringUTF8(IDS_OPTIONS_ADVANCED_SECTION_TITLE_SECURITY),
security_section_->get_page_widget(), false);
- page_ = options_builder.get_page_widget();
+ page_ = options_builder->get_page_widget();
}
« no previous file with comments | « no previous file | chrome/browser/gtk/options/content_filter_page_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698