Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Side by Side Diff: chrome/browser/gtk/options/general_page_gtk.cc

Issue 1969006: Fix 18949 on GTK ("Options" window does not fit a small display). (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: Update based on evan's comments of patch set 4 and sync with trunk Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/gtk/options/general_page_gtk.h" 5 #include "chrome/browser/gtk/options/general_page_gtk.h"
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "app/l10n_util.h" 10 #include "app/l10n_util.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 68
69 GeneralPageGtk::GeneralPageGtk(Profile* profile) 69 GeneralPageGtk::GeneralPageGtk(Profile* profile)
70 : OptionsPageBase(profile), 70 : OptionsPageBase(profile),
71 template_url_model_(NULL), 71 template_url_model_(NULL),
72 default_search_initializing_(true), 72 default_search_initializing_(true),
73 initializing_(true), 73 initializing_(true),
74 default_browser_worker_( 74 default_browser_worker_(
75 new ShellIntegration::DefaultBrowserWorker(this)), 75 new ShellIntegration::DefaultBrowserWorker(this)),
76 managed_prefs_banner_(profile->GetPrefs(), kGeneralManagablePrefs, 76 managed_prefs_banner_(profile->GetPrefs(), kGeneralManagablePrefs,
77 arraysize(kGeneralManagablePrefs)) { 77 arraysize(kGeneralManagablePrefs)) {
78 OptionsLayoutBuilderGtk options_builder; 78 scoped_ptr<OptionsLayoutBuilderGtk>
79 page_ = options_builder.get_page_widget(); 79 options_builder(OptionsLayoutBuilderGtk::CreateOptionallyCompactLayout());
80 page_ = options_builder->get_page_widget();
80 accessible_widget_helper_.reset(new AccessibleWidgetHelper(page_, profile)); 81 accessible_widget_helper_.reset(new AccessibleWidgetHelper(page_, profile));
81 82
82 options_builder.AddWidget(managed_prefs_banner_.banner_widget(), false); 83 options_builder->AddWidget(managed_prefs_banner_.banner_widget(), false);
83 options_builder.AddOptionGroup( 84 options_builder->AddOptionGroup(
84 l10n_util::GetStringUTF8(IDS_OPTIONS_STARTUP_GROUP_NAME), 85 l10n_util::GetStringUTF8(IDS_OPTIONS_STARTUP_GROUP_NAME),
85 InitStartupGroup(), true); 86 InitStartupGroup(), true);
86 options_builder.AddOptionGroup( 87 options_builder->AddOptionGroup(
87 l10n_util::GetStringUTF8(IDS_OPTIONS_HOMEPAGE_GROUP_NAME), 88 l10n_util::GetStringUTF8(IDS_OPTIONS_HOMEPAGE_GROUP_NAME),
88 InitHomepageGroup(), false); 89 InitHomepageGroup(), false);
89 options_builder.AddOptionGroup( 90 options_builder->AddOptionGroup(
90 l10n_util::GetStringUTF8(IDS_OPTIONS_DEFAULTSEARCH_GROUP_NAME), 91 l10n_util::GetStringUTF8(IDS_OPTIONS_DEFAULTSEARCH_GROUP_NAME),
91 InitDefaultSearchGroup(), false); 92 InitDefaultSearchGroup(), false);
92 #if !defined(OS_CHROMEOS) 93 #if !defined(OS_CHROMEOS)
93 options_builder.AddOptionGroup( 94 options_builder->AddOptionGroup(
94 l10n_util::GetStringUTF8(IDS_OPTIONS_DEFAULTBROWSER_GROUP_NAME), 95 l10n_util::GetStringUTF8(IDS_OPTIONS_DEFAULTBROWSER_GROUP_NAME),
95 InitDefaultBrowserGroup(), false); 96 InitDefaultBrowserGroup(), false);
96 #endif 97 #endif
97 98
98 profile->GetPrefs()->AddPrefObserver(prefs::kRestoreOnStartup, this); 99 profile->GetPrefs()->AddPrefObserver(prefs::kRestoreOnStartup, this);
99 profile->GetPrefs()->AddPrefObserver(prefs::kURLsToRestoreOnStartup, this); 100 profile->GetPrefs()->AddPrefObserver(prefs::kURLsToRestoreOnStartup, this);
100 101
101 new_tab_page_is_home_page_.Init(prefs::kHomePageIsNewTabPage, 102 new_tab_page_is_home_page_.Init(prefs::kHomePageIsNewTabPage,
102 profile->GetPrefs(), this); 103 profile->GetPrefs(), this);
103 homepage_.Init(prefs::kHomePage, profile->GetPrefs(), this); 104 homepage_.Init(prefs::kHomePage, profile->GetPrefs(), this);
(...skipping 579 matching lines...) Expand 10 before | Expand all | Expand 10 after
683 if (color) { 684 if (color) {
684 char* markup = g_markup_printf_escaped(kDefaultBrowserLabelMarkup, 685 char* markup = g_markup_printf_escaped(kDefaultBrowserLabelMarkup,
685 color, text.c_str()); 686 color, text.c_str());
686 gtk_label_set_markup(GTK_LABEL(default_browser_status_label_), markup); 687 gtk_label_set_markup(GTK_LABEL(default_browser_status_label_), markup);
687 g_free(markup); 688 g_free(markup);
688 } 689 }
689 690
690 gtk_widget_set_sensitive(default_browser_use_as_default_button_, 691 gtk_widget_set_sensitive(default_browser_use_as_default_button_,
691 state == ShellIntegration::STATE_NOT_DEFAULT); 692 state == ShellIntegration::STATE_NOT_DEFAULT);
692 } 693 }
OLDNEW
« no previous file with comments | « chrome/browser/gtk/options/fonts_page_gtk.cc ('k') | chrome/browser/gtk/options/options_layout_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698