Issue 1969005: Fix windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1969005: Fix windows build. (Closed)

Created:
10 years, 7 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
mnaganov (inactive), mnaganov

CC:
v8-dev

Visibility:
Public.

Fix windows build. SmartPointer doesn't have -> operator and conversion to bool. This a quick fix, I'll try to add -> operator with a separate CL. TBR=mnaganov@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=4594

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	src/platform-win32.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

mnaganov (inactive)

10 years, 7 months ago (2010-05-05 12:56:23 UTC) #2

On 2010/05/05 12:39:08, antonm wrote:
> Misha,
> 
> TBRed to you.

LGTM