Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 19683: Create a stub chrome executable that crashes when run. (Closed)

Created:
11 years, 10 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Create a stub chrome executable that crashes when run. This is mostly making sure we have all the symbols we need.

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : no views in unit_tests #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -27 lines) Patch
M base/base_lib.scons View 2 chunks +8 lines, -2 lines 0 comments Download
A base/idle_timer_none.cc View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/SConscript View 1 7 chunks +28 lines, -16 lines 0 comments Download
M chrome/app/chrome_exe_main.mm View 1 chunk +1 line, -1 line 0 comments Download
A chrome/app/chrome_exe_main_gtk.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/browser.scons View 1 5 chunks +7 lines, -8 lines 0 comments Download
A chrome/browser/browser_main_gtk.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/common/common.scons View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
11 years, 10 months ago (2009-01-29 23:18:40 UTC) #1
Evan Martin
11 years, 10 months ago (2009-01-29 23:23:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698