Adjust image_to_live's devserver flags to work around lab network port restrictions.

Adjust image_to_live's devserver flags to work around lab network port restrictions.

[ericli, 2010-05-04 21:39:13]

http://codereview.chromium.org/1967002/diff/1/2
File src/platform/dev/devserver.py (left):

http://codereview.chromium.org/1967002/diff/1/2#oldcode9
src/platform/dev/devserver.py:9: import SimpleHTTPServer
assume you fully tested this removal.

http://codereview.chromium.org/1967002/diff/1/3
File src/scripts/image_to_live.sh (right):

http://codereview.chromium.org/1967002/diff/1/3#newcode89
src/scripts/image_to_live.sh:89: echo
'CHROMEOS_AUSERVER=http://$HOSTNAME:8080/update' >> \
this is still hard coded.

please fully tested it before PTAL.

[ericli, 2010-05-04 23:21:58]

http://codereview.chromium.org/1967002/diff/1/3
File src/scripts/image_to_live.sh (right):

http://codereview.chromium.org/1967002/diff/1/3#newcode29
src/scripts/image_to_live.sh:29: pkill -fx ".*devserver\.py" || true
also I guess you need to sudo pkill since devserver is started by sudo now.

[seano, 2010-05-05 00:09:06]

PTAL 

On 2010/05/04 23:21:58, ericli wrote:
> http://codereview.chromium.org/1967002/diff/1/3
> File src/scripts/image_to_live.sh (right):
> 
> http://codereview.chromium.org/1967002/diff/1/3#newcode29
> src/scripts/image_to_live.sh:29: pkill -fx ".*devserver\.py" || true
> also I guess you need to sudo pkill since devserver is started by sudo now.

[ericli, 2010-05-05 00:11:16]

LGTM with one nit.

http://codereview.chromium.org/1967002/diff/6001/7002
File src/scripts/image_to_live.sh (right):

http://codereview.chromium.org/1967002/diff/6001/7002#newcode29
src/scripts/image_to_live.sh:29: ./enter_chroot.sh "sudo pkill -fx
'.*devserver\.py' || true"
you dont need to enter_chroot to kill this.

[seano, 2010-05-05 00:17:53]

http://codereview.chromium.org/1967002/diff/1/2
File src/platform/dev/devserver.py (left):

http://codereview.chromium.org/1967002/diff/1/2#oldcode9
src/platform/dev/devserver.py:9: import SimpleHTTPServer
On 2010/05/04 21:39:13, ericli wrote:
> assume you fully tested this removal.

I ran the devserver / image_to_live.sh to test it. But this import was unused in
the code anyway.

http://codereview.chromium.org/1967002/diff/1/3
File src/scripts/image_to_live.sh (right):

http://codereview.chromium.org/1967002/diff/1/3#newcode29
src/scripts/image_to_live.sh:29: pkill -fx ".*devserver\.py" || true
On 2010/05/04 23:21:58, ericli wrote:
> also I guess you need to sudo pkill since devserver is started by sudo now.

Done.

http://codereview.chromium.org/1967002/diff/1/3#newcode89
src/scripts/image_to_live.sh:89: echo
'CHROMEOS_AUSERVER=http://$HOSTNAME:8080/update' >> \
On 2010/05/04 21:39:13, ericli wrote:
> this is still hard coded.
> 
> please fully tested it before PTAL.

Fixed.

http://codereview.chromium.org/1967002/diff/6001/7002#newcode29
src/scripts/image_to_live.sh:29: pkill -fx ".*devserver\.py" || true
On 2010/05/05 00:11:16, ericli wrote:
> you dont need to enter_chroot to kill this.

The process belongs to root. I believe that this is necessary.

[seano, 2010-05-05 01:27:03]

Fixed pkill regex which was strangely never working to cleanup devserver.

http://codereview.chromium.org/1967002/diff/6001/7002
File src/scripts/image_to_live.sh (right):

http://codereview.chromium.org/1967002/diff/6001/7002#newcode29
src/scripts/image_to_live.sh:29: ./enter_chroot.sh "sudo pkill -fx
'.*devserver\.py' || true"
On 2010/05/05 00:17:53, seano wrote:
> On 2010/05/05 00:11:16, ericli wrote:
> > you dont need to enter_chroot to kill this.
> 
> The process belongs to root. I believe that this is necessary.

... though I'll take it out of the chroot :)