Add a Version class and matching unit tests, roughly based on chrome/installe...

Add a Version class and matching unit tests, roughly based on chrome/installer/util/version.*.  This version has more flexible parsing rules and is more robust to detecting bogus versions, supporting arbitrary numbers of version components rather than just dotted quads.  It's possible that we should switch chrome installer to use this version.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8901

[kuchhal, 2009-01-29 18:20:00]

lgtm.

two nits below.

http://codereview.chromium.org/19667/diff/210/214
File base/version.h (right):

http://codereview.chromium.org/19667/diff/210/214#newcode21
Line 21: virtual ~Version() {}
This class doesn't have any virtual functions. Do we still want destructor as
virtual?

http://codereview.chromium.org/19667/diff/210/218
File base/version_unittest.cc (right):

http://codereview.chromium.org/19667/diff/210/218#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2009

[Aaron Boodman, 2009-01-29 19:16:46]

Nice, LGTM

http://codereview.chromium.org/19667/diff/17/24
File base/version.cc (right):

http://codereview.chromium.org/19667/diff/17/24#newcode19
Line 19: Version* vers = new Version();
Could use scoped_ptr<> here

http://codereview.chromium.org/19667/diff/17/24#newcode43
Line 43: if (components_.size() > other_components.size()) {
Interesting... I hadn't thought about the issue of comparing 1.0 to 1.0.0.0, but
this seems reasonable.

http://codereview.chromium.org/19667/diff/17/24#newcode80
Line 80: if (IntToString(num) != *i)
Makes sense.