Adding the minidump unit test to Windows. This test comes from Chromium.

Copied minidump_test.cc from chrome_frame (see http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/crash_reporting/minidump_test.cc). 
I had to remove the dependency from base (was using FilePath and ScopedHandle, replaced them by standard std::wstring and HANDLE). Also removed the logging and the main from the original files.

This will serve as a base for testing breakpad's dump generation. It is kept like this for easier tracking.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=592

[Sigurður Ásgeirsson, 2010-05-05 19:56:21]

This looks fine to commit, but it's not terribly useful to breakpad. If you
elect to submit this as is, please add a comment to the changelist description
that more is coming.

http://codereview.chromium.org/1964006/diff/8001/9002
File src/client/windows/unittests/minidump_test.cc (right):

http://codereview.chromium.org/1964006/diff/8001/9002#newcode452
src/client/windows/unittests/minidump_test.cc:452:
ASSERT_TRUE(WriteDump(kFullDumpType));
while these tests are really cool :), they only really test whether particular
sets of flags to MiniDumpWriteDump work across a set of the platforms we use. 
You have plans to add breakpad tests to this?

[Sigurður Ásgeirsson, 2010-05-05 21:00:59]

So, per our offline conversation, if you amend the CL description with the
provenance of the file, and the fact that you're checking in a semi-pristine
copy for easier tracking, this'd lgtm.

On Wed, May 5, 2010 at 3:56 PM, <siggi@chromium.org> wrote:

> This looks fine to commit, but it's not terribly useful to breakpad. If you
> elect to submit this as is, please add a comment to the changelist
> description
> that more is coming.
>
>
> http://codereview.chromium.org/1964006/diff/8001/9002
> File src/client/windows/unittests/minidump_test.cc (right):
>
> http://codereview.chromium.org/1964006/diff/8001/9002#newcode452
> src/client/windows/unittests/minidump_test.cc:452:
> ASSERT_TRUE(WriteDump(kFullDumpType));
> while these tests are really cool :), they only really test whether
> particular sets of flags to MiniDumpWriteDump work across a set of the
> platforms we use.
> You have plans to add breakpad tests to this?
>
>
> http://codereview.chromium.org/1964006/show
>