Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1964006: Adding the minidump unit test to Windows. This test comes from Chromium. (Closed)

Created:
10 years, 7 months ago by hansl_g
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Copied minidump_test.cc from chrome_frame (see http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/crash_reporting/minidump_test.cc). I had to remove the dependency from base (was using FilePath and ScopedHandle, replaced them by standard std::wstring and HANDLE). Also removed the logging and the main from the original files. This will serve as a base for testing breakpad's dump generation. It is kept like this for easier tracking. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=592

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -0 lines) Patch
M src/client/windows/unittests/client_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/client/windows/unittests/gtest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A src/client/windows/unittests/minidump_test.cc View 1 2 3 1 chunk +482 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hansl_g
10 years, 7 months ago (2010-05-05 19:23:42 UTC) #1
Sigurður Ásgeirsson
This looks fine to commit, but it's not terribly useful to breakpad. If you elect ...
10 years, 7 months ago (2010-05-05 19:56:21 UTC) #2
Sigurður Ásgeirsson
10 years, 7 months ago (2010-05-05 21:00:59 UTC) #3
So, per our offline conversation, if you amend the CL description with the
provenance of the file, and the fact that you're checking in a semi-pristine
copy for easier tracking, this'd lgtm.

On Wed, May 5, 2010 at 3:56 PM, <siggi@chromium.org> wrote:

> This looks fine to commit, but it's not terribly useful to breakpad. If you
> elect to submit this as is, please add a comment to the changelist
> description
> that more is coming.
>
>
> http://codereview.chromium.org/1964006/diff/8001/9002
> File src/client/windows/unittests/minidump_test.cc (right):
>
> http://codereview.chromium.org/1964006/diff/8001/9002#newcode452
> src/client/windows/unittests/minidump_test.cc:452:
> ASSERT_TRUE(WriteDump(kFullDumpType));
> while these tests are really cool :), they only really test whether
> particular sets of flags to MiniDumpWriteDump work across a set of the
> platforms we use.
> You have plans to add breakpad tests to this?
>
>
> http://codereview.chromium.org/1964006/show
>

Powered by Google App Engine
This is Rietveld 408576698