Issue 196140: Re-applying build/common.gypi patch from http://codereview.chromium.org/19507...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196140: Re-applying build/common.gypi patch from http://codereview.chromium.org/19507... (Closed)

Created:
11 years, 3 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

BUG=11927 Re-applying build/common.gypi patch from http://codereview.chromium.org/195078 The previous patch was reverted until buildbot master was restarted. After the restart, GYP_DEFINES contains "release_valgrind_build=1" http://build.chromium.org/buildbot/waterfall/builders/Chromium Linux Builder (valgrind)/builds/2/steps/gclient/logs/stdio Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26564

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	build/common.gypi	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Timur Iskhodzhanov

Hi Dan, Can you please review this changelist? Thank you, Timur Iskhodzhanov

11 years, 3 months ago (2009-09-17 14:42:57 UTC) #1

LGTM but be ready to revert if it makes anything go red.