Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: src/v8.cc

Issue 196139: X64: Convert smis to holding 32 bits of payload. (Closed)
Patch Set: Addressed review comments. Forwarded to head. Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/utils.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 171
172 bool V8::IdleNotification() { 172 bool V8::IdleNotification() {
173 // Returning true tells the caller that there is no need to call 173 // Returning true tells the caller that there is no need to call
174 // IdleNotification again. 174 // IdleNotification again.
175 if (!FLAG_use_idle_notification) return true; 175 if (!FLAG_use_idle_notification) return true;
176 176
177 // Tell the heap that it may want to adjust. 177 // Tell the heap that it may want to adjust.
178 return Heap::IdleNotification(); 178 return Heap::IdleNotification();
179 } 179 }
180 180
181 static const uint32_t kRandomPositiveSmiMax = 0x3fffffff;
181 182
182 Smi* V8::RandomPositiveSmi() { 183 Smi* V8::RandomPositiveSmi() {
183 uint32_t random = Random(); 184 uint32_t random = Random();
184 ASSERT(IsPowerOf2(Smi::kMaxValue + 1)); 185 ASSERT(static_cast<uint32_t>(Smi::kMaxValue) >= kRandomPositiveSmiMax);
185 return Smi::FromInt(random & Smi::kMaxValue); 186 // kRandomPositiveSmiMax must match the value being divided
187 // by in math.js.
188 return Smi::FromInt(random & kRandomPositiveSmiMax);
186 } 189 }
187 190
188 } } // namespace v8::internal 191 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/utils.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698