Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 196126: Fix LayoutTests/plugins/destroy-during-npp-new.html... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Fix LayoutTests/plugins/destroy-during-npp-new.html We crash if we try to report geometry for a plugin that has been removed from the DOM. This CL makes changes to main.cpp to support the layout test, which corresponds to http://trac.webkit.org/changeset/48361. R=jam BUG=21841 TEST=covered by layout test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M webkit/api/src/WebPluginContainerImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/npapi_layout_test_plugin/main.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 3 months ago (2009-09-15 17:21:57 UTC) #1
jam
11 years, 3 months ago (2009-09-15 18:05:21 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698