Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 196125: Extensions: tab.title should not be undefined. (Closed)

Created:
11 years, 3 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Extensions: tab.title should not be undefined. (If you request tab information while the page is loading, the tab.title is undefined and it shouldn't be.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
[This fixes the issue I talked about last night on chromium-dev, but I'm not familiar ...
11 years, 3 months ago (2009-09-15 17:15:19 UTC) #1
Aaron Boodman
+rafaelw
11 years, 3 months ago (2009-09-15 17:53:01 UTC) #2
Erik does not do reviews
I'll defer to rafaelw on this one. My memory was that there were some tricky ...
11 years, 3 months ago (2009-09-15 17:56:29 UTC) #3
rafaelw
I remember that there was a reason for not sending title when status is "loading". ...
11 years, 3 months ago (2009-09-15 23:21:25 UTC) #4
rafaelw
11 years, 3 months ago (2009-09-18 00:41:40 UTC) #5
I thought there was a reason not to send title while the page was loading, but I
couldn't produce or think of an error case.

Thanks for doing this.

LGTM

Powered by Google App Engine
This is Rietveld 408576698