Add "New Window" and "New Incognito Window" items to the Dock Menu....

chrome/browser/app_controller_mac.mm

Index: chrome/browser/app_controller_mac.mm
===================================================================
--- chrome/browser/app_controller_mac.mm	(revision 26116)
+++ chrome/browser/app_controller_mac.mm	(working copy)
@@ -4,7 +4,7 @@
 
 #import "chrome/browser/app_controller_mac.h"
 
-#include "app/l10n_util.h"
+#include "app/l10n_util_mac.h"
 #include "base/command_line.h"
 #include "base/mac_util.h"
 #include "base/message_loop.h"
@@ -48,6 +48,7 @@
 - (void)windowLayeringDidChange:(NSNotification*)inNotification;
 - (BOOL)userWillWaitForInProgressDownloads:(int)downloadCount;
 - (BOOL)shouldQuitWithInProgressDownloads;
+- (NSMenu*)applicationDockMenu:(NSApplication*)sender;
 @end
 
 @implementation AppController
@@ -666,4 +667,28 @@
   [aboutController_ showWindow:self];
 }
 
+- (NSMenu*)applicationDockMenu:(id)sender {
+  NSMenu* result = [[[NSMenu alloc] initWithTitle: @""] autorelease];

[pink (ping after 24hrs), 2009/09/14 19:13:03]

rather than autoreleasing, we prefer to use scoped_nsobject<T> since we have it
in Chromium.

[John Grabowski, 2009/09/14 21:22:22]

For this line here, I don't think so.
If it was a scoped_nsobject the returned value would be invalid before being
used by the caller.
Given the necessary use of autorelease, it makes some sense to follow the
pattern of autorelease instead of scoped_nsobject in the rest of the function.

Yes, we could scope_nsobject it, then retain+autorelease before returning it,
but it isn't clear that is better.

[sgk, 2009/09/14 22:10:53]

In fact, it does fail as you'd expect (message sent to freed object) if you just
replace this line with a scoped_nsobject initialization.

Following up with a CL for the other stylistic changes.

+  NSString* titleStr;

[pink (ping after 24hrs), 2009/09/14 19:13:03]

these should be declared on the same line as they are initialized.

+  id item;
+
+  titleStr = l10n_util::GetNSStringWithFixup(IDS_NEW_WINDOW_MAC);
+  item = [[[NSMenuItem alloc] initWithTitle:titleStr
+                                     action:@selector(commandDispatch:)
+                              keyEquivalent:@""] autorelease];
+  [item setTarget:self];
+  [item setTag:IDC_NEW_WINDOW];
+  [result addItem:item];
+
+  titleStr = l10n_util::GetNSStringWithFixup(IDS_NEW_INCOGNITO_WINDOW_MAC);
+  item = [[[NSMenuItem alloc] initWithTitle:titleStr
+                                     action:@selector(commandDispatch:)
+                              keyEquivalent:@""] autorelease];
+  [item setTarget:self];
+  [item setTag:IDC_NEW_INCOGNITO_WINDOW];
+  [result addItem:item];
+
+  return result;
+}
+
 @end