Issue 196081: Use base::WindowImpl instead of CWindowImpl to remove a dependency on ATL....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196081: Use base::WindowImpl instead of CWindowImpl to remove a dependency on ATL.... (Closed)

Created:
11 years, 3 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use base::WindowImpl instead of CWindowImpl to remove a dependency on ATL. BUG=5027 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25925

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -15 lines)			Patch
	M	tools/memory_watcher/hotkey.h	View		1 chunk	+15 lines, -15 lines	0 comments	Download
	M	tools/memory_watcher/memory_watcher.gyp	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/196081/diff/1/3 File tools/memory_watcher/memory_watcher.gyp (right): http://codereview.chromium.org/196081/diff/1/3#newcode23 Line 23: # TODO(beng): move wtl to src/third_party Do ...

11 years, 3 months ago (2009-09-10 21:19:38 UTC) #2

James Hawkins

On 2009/09/10 21:19:38, Peter Kasting wrote: > LGTM > > http://codereview.chromium.org/196081/diff/1/3 > File tools/memory_watcher/memory_watcher.gyp (right): ...

11 years, 3 months ago (2009-09-10 21:23:20 UTC) #3

Peter Kasting

11 years, 3 months ago (2009-09-10 21:25:03 UTC) #4

On 2009/09/10 21:23:20, James Hawkins wrote:
> On 2009/09/10 21:19:38, Peter Kasting wrote:
> > Do you need this?
> 
> Yea, I'm thinking about doing the move myself, and this is a line I can grep
for
> to catch all the use cases.

No, I meant do you actually need that include dir.  I can't see how your change
could add it as a dependency.

Expand Messages | Collapse Messages