Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 196069: Rebaseline more of fast/repaint tests we are now passing.... (Closed)

Created:
11 years, 3 months ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
Julie Parent
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Rebaseline more of fast/repaint tests we are now passing. The difference between repaint areas is due to the difference in repaint logic. Safari/Mac port uses NSView's native rectangle collection/unification, and we just unify all into one damage rect. R=jparent BUG=8630 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -12 lines) Patch
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/selection-gap-overflow-scroll-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/selection-gap-overflow-scroll-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/static-to-positioned-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/static-to-positioned-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/subtree-root-skipped-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/subtree-root-skipped-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-cell-collapsed-border-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-cell-collapsed-border-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-cell-move-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-cell-move-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-cell-vertical-overflow-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-collapsed-border-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-collapsed-border-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-extra-bottom-grow-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-extra-bottom-grow-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-outer-border-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-section-repaint-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/table-two-pass-layout-overpaint-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/text-append-dirty-lines-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/text-append-dirty-lines-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/selection-gap-overflow-scroll-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/selection-gap-overflow-scroll-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/selection-gap-overflow-scroll-expected.txt View 1 chunk +29 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/static-to-positioned-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/static-to-positioned-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/static-to-positioned-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/subtree-root-skipped-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/subtree-root-skipped-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/subtree-root-skipped-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-cell-collapsed-border-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-cell-collapsed-border-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-cell-collapsed-border-expected.txt View 1 chunk +40 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-cell-move-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-cell-move-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-cell-move-expected.txt View 1 chunk +43 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-cell-vertical-overflow-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-cell-vertical-overflow-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-collapsed-border-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-collapsed-border-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-collapsed-border-expected.txt View 1 chunk +73 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-extra-bottom-grow-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-extra-bottom-grow-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-extra-bottom-grow-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-outer-border-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-outer-border-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-section-repaint-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-section-repaint-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-two-pass-layout-overpaint-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/table-two-pass-layout-overpaint-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/text-append-dirty-lines-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/text-append-dirty-lines-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/text-append-dirty-lines-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dglazkov
11 years, 3 months ago (2009-09-09 20:55:35 UTC) #1
Julie Parent
11 years, 3 months ago (2009-09-09 21:03:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698