Issue 196065: Use a text cell that does fade-to-truncate from GTM. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196065: Use a text cell that does fade-to-truncate from GTM. ... (Closed)

Created:
11 years, 3 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Use a text cell that does fade-to-truncate from GTM. BUG=20711, 20726 TEST=tab titles look better when long Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25757

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -527 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/nibs/TabView.xib	View	22 chunks	+36 lines, -526 lines	1 comment	Download
M	chrome/chrome.gyp	View	3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

11 years, 3 months ago (2009-09-09 17:29:26 UTC) #2

LGTM

http://codereview.chromium.org/196065/diff/1/2
File chrome/app/nibs/TabView.xib (right):

http://codereview.chromium.org/196065/diff/1/2#newcode2
Line 2: <archive type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="7.03">
No SL at home? =)

Expand Messages | Collapse Messages