Issue 196060: DevTools: A quick fix to enable interactive_ui_tests....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196060: DevTools: A quick fix to enable interactive_ui_tests.... (Closed)

Created:
11 years, 3 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org, Ben Goodger (Google), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: A quick fix to enable interactive_ui_tests. Need to figure out why settings are inavailable through InspectorController. For now, just stub them. BUG=http://crbug.com/21277 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25711

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -10 lines)			Patch
	M	chrome/browser/debugger/devtools_sanity_unittest.cc	View		2 chunks	+10 lines, -10 lines	0 comments	Download
	M	webkit/glue/devtools/js/inspector_controller.js	View	1	2 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

http://codereview.chromium.org/196060/diff/1/2 File webkit/glue/devtools/js/inspector_controller.js (right): http://codereview.chromium.org/196060/diff/1/2#newcode494 Line 494: } missing ; http://codereview.chromium.org/196060/diff/1/2#newcode503 Line 503: } missing ...

11 years, 3 months ago (2009-09-09 08:01:21 UTC) #2

mnaganov (inactive)

11 years, 3 months ago (2009-09-09 08:02:58 UTC) #4

http://codereview.chromium.org/196060/diff/1/2
File webkit/glue/devtools/js/inspector_controller.js (right):

http://codereview.chromium.org/196060/diff/1/2#newcode494
Line 494: }
On 2009/09/09 08:01:21, Yury Semikhatsky wrote:
> missing ;

Done.

http://codereview.chromium.org/196060/diff/1/2#newcode503
Line 503: }
On 2009/09/09 08:01:21, Yury Semikhatsky wrote:
> missing ;

Done.

Expand Messages | Collapse Messages