When converting between units of time or data types of different precision,...

webkit/glue/webkitclient_impl.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.  Use of this
 // source code is governed by a BSD-style license that can be found in the
 // LICENSE file.
 
+#include <math.h>
 #include "config.h"
 
 #include "FrameView.h"
 #include "ScrollView.h"
 #include <wtf/Assertions.h>
 #undef LOG
 
 #include "webkit/glue/webkitclient_impl.h"
 
 #include "base/file_path.h"
@@ skipping 243 matching lines @@
 
 double WebKitClientImpl::currentTime() {
   return base::Time::Now().ToDoubleT();
 }
 
 void WebKitClientImpl::setSharedTimerFiredFunction(void (*func)()) {
   shared_timer_func_ = func;
 }
 
 void WebKitClientImpl::setSharedTimerFireTime(double fire_time) {
-  int interval = static_cast<int>((fire_time - currentTime()) * 1000);
+  // By converting between double and int64 representation, we run the risk
+  // of losing precision due to rounding errors. Performing computations in
+  // microseconds reduces this risk somewhat. But there still is the potential
+  // of us computing a fire time for the timer that is shorter than what we
+  // need.
+  // As the event loop will check event deadlines prior to actually firing
+  // them, there is a risk of needlessly rescheduling events and of
+  // needlessly looping if sleep times are too short even by small amounts.
+  // This results in measurable performance degradation unless we use ceil() to
+  // always round up the sleep times.
+  int64 interval = static_cast<int64>(
+      ceil((fire_time - currentTime()) * base::Time::kMicrosecondsPerSecond));
   if (interval < 0)
     interval = 0;
 
   shared_timer_.Stop();
-  shared_timer_.Start(base::TimeDelta::FromMilliseconds(interval), this,
+  shared_timer_.Start(base::TimeDelta::FromMicroseconds(interval), this,
                       &WebKitClientImpl::DoTimeout);
 }
 
 void WebKitClientImpl::stopSharedTimer() {
   shared_timer_.Stop();
 }
 
 void WebKitClientImpl::callOnMainThread(void (*func)()) {
   main_loop_->PostTask(FROM_HERE, NewRunnableFunction(func));
 }
@@ skipping 172 matching lines @@
   ChromeClientImpl* chrome_client = ToChromeClient(widget);
   if (chrome_client)
     chrome_client->focus();
 }
 
 WebCore::WorkerContextProxy* WebKitClientImpl::createWorkerContextProxy(
     WebCore::Worker* worker) {
   return WebWorkerClientImpl::createWorkerContextProxy(worker);
 }
 }  // namespace webkit_glue