Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 196046: Fix installer_util_strings project with incredibuild.... (Closed)

Created:
11 years, 3 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, kuchhal
Visibility:
Public.

Description

Fix installer_util_strings project with incredibuild. It was failing to generate $(OutDir)\obj\global_intermediate\installer_util_strings\installer_util_strings.* TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25694

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -31 lines) Patch
M chrome/installer/installer.gyp View 1 1 chunk +15 lines, -21 lines 2 comments Download
D chrome/installer/util/prebuild/create_string_rc.bat View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/installer/util/prebuild/create_string_rc.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
Tested on Google Chrome XP slave which was exhibiting the issue.
11 years, 3 months ago (2009-09-08 20:34:59 UTC) #1
M-A Ruel
Added back direct_dependent_settings that I had stripped off by inadvertance.
11 years, 3 months ago (2009-09-08 20:52:22 UTC) #2
Nicolas Sylvain
can you describe the patch is words please. That might make the change move obvious.
11 years, 3 months ago (2009-09-08 20:54:29 UTC) #3
M-A Ruel
In installer_util_strings, I changed from 'actions' to 'rules' so it is generated as a VS-friendly ...
11 years, 3 months ago (2009-09-08 20:59:56 UTC) #4
bradn
11 years, 3 months ago (2009-09-08 21:14:37 UTC) #5
LGTM

This is great  (particularly that it works on the builder!!!) So are you saying
that incredibuild does not correctly handle the case where custom build steps
have outputs used by another module which is marked as dependent, but does
handle Custom build rule outputs? I know that in the past nsylvain and I had
perturbed this around until it started working, but understanding the cause
would be much better. 

Had you been seeing this fail with IB the way it currently was? What prompted
this? I've been blocked on bumping the gyp version because  it with gyp version
638 it will consistently fail on installer util strings. Ideally we'd try that
change on top of this (it changes some quoting, which was enough to make it
angry).

If there is a general issue like this with Custom Build Steps + IB, we need to
change the generator not to use them. It would seem this would have the
potential to affect all sorts of things.

http://codereview.chromium.org/196046/diff/2001/3001
File chrome/installer/installer.gyp (right):

http://codereview.chromium.org/196046/diff/2001/3001#newcode180
Line 180: 'type': 'dummy_executable',
Can this turn into 'none' after this change?

http://codereview.chromium.org/196046/diff/2001/3001#newcode192
Line 192: 'action': ['../../third_party/python_24/python.exe',
without msvs_cygwin_shell:0, you should be able to make this just 'python'

Powered by Google App Engine
This is Rietveld 408576698