Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 196044: GTK Theme: Don't render IDR_THEME_TOOLBAR on GtkWidgets. (Closed)

Created:
11 years, 3 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
tony, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

GTK Theme: Don't render IDR_THEME_TOOLBAR on GtkWidgets. IDR_THEME_TOOLBAR is a generated blank image of the bg[SELECTED] color, which will be drawn by default on GtkWidgets. Uploading an image of said color to the X server on each expose and then asking it to tile the image across the widget is silly; stop doing it. Also sets clip rectangles correctly in a few places where we were using GdkGC instead of skia. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/gtk/bookmark_bar_gtk.cc View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/find_bar_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/rounded_window.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
11 years, 3 months ago (2009-09-08 17:29:12 UTC) #1
Evan Martin
11 years, 3 months ago (2009-09-08 18:32:03 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698