Pretty-up the blocked popup view by sharing code from the status bubble. Bloc...

Pretty-up the blocked popup view by sharing code from the status bubble. Blocked Popup view is now themed as well.
BUG=20815
TEST=popup blocking and status bubble still work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25662

[rohitrao (ping after 24h), 2009-09-08 19:25:20]

LGTM

http://codereview.chromium.org/196043/diff/1/7
File chrome/browser/cocoa/blocked_popup_container_controller.mm (right):

http://codereview.chromium.org/196043/diff/1/7#newcode119
Line 119: [closeButton_
setAlternateImage:nsimage_cache::ImageNamed(@"close_bar_p.pdf")];
Line too long.

http://codereview.chromium.org/196043/diff/1/6
File chrome/browser/cocoa/bubble_view.mm (right):

http://codereview.chromium.org/196043/diff/1/6#newcode101
Line 101: border = [NSBezierPath gtm_bezierPathWithRoundRect:bounds
Isn't this the same path as above?

http://codereview.chromium.org/196043/diff/1/3
File chrome/browser/cocoa/bubble_view_unittest.mm (right):

http://codereview.chromium.org/196043/diff/1/3#newcode49
Line 49: // Make sure things don't go haywire when given invalid or extra-long
strings
Is there any value in testing displaying extra-long strings?

[pink (ping after 24hrs), 2009-09-08 19:50:17]

http://codereview.chromium.org/196043/diff/1/7
File chrome/browser/cocoa/blocked_popup_container_controller.mm (right):

http://codereview.chromium.org/196043/diff/1/7#newcode119
Line 119: [closeButton_
setAlternateImage:nsimage_cache::ImageNamed(@"close_bar_p.pdf")];
On 2009/09/08 19:25:21, rohitrao wrote:
> Line too long.

Done.

http://codereview.chromium.org/196043/diff/1/6
File chrome/browser/cocoa/bubble_view.mm (right):

http://codereview.chromium.org/196043/diff/1/6#newcode101
Line 101: border = [NSBezierPath gtm_bezierPathWithRoundRect:bounds
On 2009/09/08 19:25:21, rohitrao wrote:
> Isn't this the same path as above?

good catch, this was from the original code.

http://codereview.chromium.org/196043/diff/1/3
File chrome/browser/cocoa/bubble_view_unittest.mm (right):

http://codereview.chromium.org/196043/diff/1/3#newcode49
Line 49: // Make sure things don't go haywire when given invalid or extra-long
strings
On 2009/09/08 19:25:21, rohitrao wrote:
> Is there any value in testing displaying extra-long strings?

No, not really. I can remove.