Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 196029: Simple fix of extension_l10n_util that allows folders in form ".some_name" to... (Closed)

Created:
11 years, 3 months ago by Nebojša Ćirić
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org, Ben Goodger (Google), Paweł Hajdan Jr.
Visibility:
Public.

Description

Simple fix of extension_l10n_util that allows folders in form ".some_name" to exist in _locales folder. It helps testing/loading extensions from svn tree (skips .svn folder, doesn't fail).

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Messages

Total messages: 4 (0 generated)
Nebojša Ćirić
This is a fix for the other CL you are already reviewing (so I can ...
11 years, 3 months ago (2009-09-04 20:38:54 UTC) #1
Nebojša Ćirić
We already talked about doing this (for easier testing). It's a prequel for the other ...
11 years, 3 months ago (2009-09-04 20:39:50 UTC) #2
Aaron Boodman
lgtm http://codereview.chromium.org/196029/diff/2001/2005 File chrome/browser/extensions/extension_l10n_util.cc (right): http://codereview.chromium.org/196029/diff/2001/2005#newcode42 Line 42: if (locale_name->find(".", 0) == 0) { Nit: ...
11 years, 3 months ago (2009-09-09 01:42:56 UTC) #3
Nebojša Ćirić
11 years, 3 months ago (2009-09-09 20:06:45 UTC) #4
All done, thanks.

On 2009/09/09 01:42:56, Aaron Boodman wrote:
> lgtm
> 
> http://codereview.chromium.org/196029/diff/2001/2005
> File chrome/browser/extensions/extension_l10n_util.cc (right):
> 
> http://codereview.chromium.org/196029/diff/2001/2005#newcode42
> Line 42: if (locale_name->find(".", 0) == 0) {
> Nit: braces not needed.
> 
> http://codereview.chromium.org/196029/diff/2001/2005#newcode42
> Line 42: if (locale_name->find(".", 0) == 0) {
> Nit: second parameter unnecessary as 0 is the default values.

Powered by Google App Engine
This is Rietveld 408576698