Issue 196024: Last step in allocating objects in generated code on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196024: Last step in allocating objects in generated code on ARM (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Last step in allocating objects in generated code on ARM. Port specialized constructor code for constructing simple objects to ARM. See http://codereview.chromium.org/173470 for description. Committed: http://code.google.com/p/v8/source/detail?r=2834

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -1 line)			Patch
	M	src/arm/stub-cache-arm.cc	View	1	1 chunk	+136 lines, -1 line	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/196024/diff/2001/3001 File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/196024/diff/2001/3001#newcode1364 Line 1364: __ cmp(r2, r7); I'd like to see ...

11 years, 3 months ago (2009-09-07 10:21:45 UTC) #2

Søren Thygesen Gjesse

11 years, 3 months ago (2009-09-07 10:26:43 UTC) #3

http://codereview.chromium.org/196024/diff/2001/3001
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/196024/diff/2001/3001#newcode1364
Line 1364: __ cmp(r2, r7);
On 2009/09/07 10:21:45, Erik Corry wrote:
> I'd like to see a performance bot run with and without this.

I will do that.

http://codereview.chromium.org/196024/diff/2001/3001#newcode1396
Line 1396: ASSERT(Heap::MaxObjectSizeInPagedSpace() >=
JSObject::kMaxInstanceSize);
On 2009/09/07 10:21:45, Erik Corry wrote:
> Unnecessary assert.

Done.

Expand Messages | Collapse Messages