Properly concatenate URL components in directory listing.

Properly concatenate URL components in directory listing.

This time really properly.

TEST=none
http://crbug.com/20347

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25624

[Paweł Hajdan Jr., 2009-09-04 00:01:21]

I think I tested it better now. No double slashes, things work.

[wtc, 2009-09-04 18:08:08]

LGTM, but I'm not a JavaScript programmer.

eroman, could you take a look too?

http://codereview.chromium.org/196019/diff/1/2
File net/base/dir_header.html (right):

http://codereview.chromium.org/196019/diff/1/2#newcode10
Line 10: var root = "" + document.location;
Just curious, why do we need the ""?

Would "parent_dir" or "current_dir" be a better name
than "root"?

[eroman, 2009-09-04 18:50:32]

I don't quite understand why we are doing the absolute pathing in javascript?
Can't we just have the URL end in a "/" when it is a directory?

http://codereview.chromium.org/196019/diff/1/2
File net/base/dir_header.html (right):

http://codereview.chromium.org/196019/diff/1/2#newcode10
Line 10: var root = "" + document.location;
On 2009/09/04 18:08:09, wtc wrote:
> Just curious, why do we need the ""?
> 
> Would "parent_dir" or "current_dir" be a better name
> than "root"?

Instead of document.location, you can use document.URL, which is already a
DOMString, and doesn't need to be stringized (also to stringize you could have
done document.location.toString())

[eroman, 2009-09-04 22:49:00]

lgtm