Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1958002: Prevent git from using any external diff program that may have been... (Closed)

Created:
10 years, 7 months ago by Scott Byer
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Prevent git from using any external diff program that may have been configured for it when figuring out the patch to upload to the try server. This prevents git installations where the diff is configured to use an interactive tool to work without doing nasty workarounds. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M scm.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
LGTM
10 years, 7 months ago (2010-05-05 16:25:02 UTC) #1
Scott Byer
On 2010/05/05 16:25:02, Evan Martin wrote: > LGTM Commit for me? Thanks!
10 years, 7 months ago (2010-05-05 16:47:42 UTC) #2
Evan Martin
10 years, 7 months ago (2010-05-19 14:24:53 UTC) #3
committed

Powered by Google App Engine
This is Rietveld 408576698