Issue 19541: Fixing the flakiness of the serialization tests by assuring that serializatio...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19541: Fixing the flakiness of the serialization tests by assuring that serializatio... (Closed)

Created:
11 years, 10 months ago by olehougaard

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixing the flakiness of the serialization tests by assuring that serialization is run before every deserialization test. Committed: http://code.google.com/p/v8/source/detail?r=1214

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -25 lines)			Patch
M	test/cctest/cctest.h	View	1	2 chunks	+16 lines, -7 lines	0 comments	Download
M	test/cctest/cctest.cc	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/testcfg.py	View	1	2 chunks	+21 lines, -7 lines	2 comments	Download
M	tools/test.py	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

Lgtm! http://codereview.chromium.org/19541/diff/201/1203 File test/cctest/testcfg.py (right): http://codereview.chromium.org/19541/diff/201/1203#newcode66 Line 66: self.RunCommand(dependent_command) Consider checking that this command didn't ...

11 years, 10 months ago (2009-02-03 08:21:16 UTC) #2

olehougaard

11 years, 10 months ago (2009-02-03 08:34:26 UTC) #3

http://codereview.chromium.org/19541/diff/201/1203
File test/cctest/testcfg.py (right):

http://codereview.chromium.org/19541/diff/201/1203#newcode66
Line 66: self.RunCommand(dependent_command)
On 2009/02/03 08:21:16, Christian Plesner Hansen wrote:
> Consider checking that this command didn't fail and returning the command
output
> if it did.

Done

Expand Messages | Collapse Messages

Issue 19541: Fixing the flakiness of the serialization tests by assuring that serializatio... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages