Issue 19538: The optimizations performed by Irregexp could possible hide bugs or...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19538: The optimizations performed by Irregexp could possible hide bugs or... (Closed)

Created:
11 years, 10 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

The optimizations performed by Irregexp could possible hide bugs or could themselves be a source of bugs. Add a flag to switch off optimizations (--noirregexp-optimization) to aid testing. Committed: http://code.google.com/p/v8/source/detail?r=1210

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	src/flag-definitions.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/jsregexp.cc	View		3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

11 years, 10 months ago (2009-02-02 15:45:44 UTC) #2

Lgtm.

Have you tried to run the Big(TM) test with optimizations disabled?

Expand Messages | Collapse Messages