Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 195107: Refactor gyp_chromium so you don't have to execute it from the src/.. directo... (Closed)

Created:
11 years, 3 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mark Mentovai, yaar
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Refactor gyp_chromium so you don't have to execute it from the src/.. directory. BUG=none TEST='python src/build/gyp_chromium; cd src; python build/gyp_chromium; cd build; python gyp_chromium' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26408

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M build/gyp_chromium View 1 2 3 1 chunk +16 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sgk
11 years, 3 months ago (2009-09-16 21:52:04 UTC) #1
Mark Mentovai
I fixed some (but not all) of this earlier today. Can you resync?
11 years, 3 months ago (2009-09-16 21:54:46 UTC) #2
sgk
Updated w/mark's chrome_src changes.
11 years, 3 months ago (2009-09-16 22:26:32 UTC) #3
Mark Mentovai
11 years, 3 months ago (2009-09-16 22:28:25 UTC) #4
LGTM.  Can you keep o3d/build/gyp_o3d in sync too?

Powered by Google App Engine
This is Rietveld 408576698