Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: chrome/browser/cocoa/find_bar_bridge.mm

Issue 195105: [Mac] Adds animations to the findbar.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/find_bar_bridge.mm
===================================================================
--- chrome/browser/cocoa/find_bar_bridge.mm (revision 26362)
+++ chrome/browser/cocoa/find_bar_bridge.mm (working copy)
@@ -14,11 +14,11 @@
}
void FindBarBridge::Show() {
- [cocoa_controller_ showFindBar];
+ [cocoa_controller_ showFindBar:YES]; // with animation.
}
void FindBarBridge::Hide(bool animate) {
- [cocoa_controller_ hideFindBar];
+ [cocoa_controller_ hideFindBar:(animate ? YES : NO)];
}
void FindBarBridge::SetFocusAndSelection() {
@@ -52,18 +52,19 @@
}
void FindBarBridge::StopAnimation() {
- // Do nothing here, this appears necessary only for the windows impl.
+ [cocoa_controller_ stopAnimation];
}
gfx::Rect FindBarBridge::GetDialogPosition(gfx::Rect avoid_overlapping_rect) {
- NOTIMPLEMENTED();
+ // http://crbug.com/22036
return gfx::Rect();
}
void FindBarBridge::SetDialogPosition(const gfx::Rect& new_pos,
bool no_redraw) {
// TODO(rohitrao): Do something useful here. For now, just show the findbar.
- Show();
+ // http://crbug.com/22036
+ [cocoa_controller_ showFindBar:NO]; // Do not animate.
}
void FindBarBridge::RestoreSavedFocus() {

Powered by Google App Engine
This is Rietveld 408576698