Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1649)

Unified Diff: chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm

Issue 195105: [Mac] Adds animations to the findbar.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm (revision 26362)
+++ chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm (working copy)
@@ -17,11 +17,16 @@
// Expose private variables to make testing easier.
@interface FindBarCocoaController(Testing)
+- (NSView*)findBarView;
- (NSTextField*)findText;
- (NSTextField*)resultsLabel;
@end
@implementation FindBarCocoaController(Testing)
+- (NSView*)findBarView {
+ return findBarView_;
+}
+
- (NSTextField*)findText {
return findText_;
}
@@ -50,27 +55,26 @@
};
TEST_F(FindBarCocoaControllerTest, ShowAndHide) {
- NSView* findBarView = [controller_ view];
+ NSView* findBarView = [controller_ findBarView];
- ASSERT_TRUE([findBarView isHidden]);
+ ASSERT_GT([findBarView frame].origin.y, 0);
ASSERT_FALSE([controller_ isFindBarVisible]);
- [controller_ showFindBar];
- EXPECT_FALSE([findBarView isHidden]);
+ [controller_ showFindBar:NO];
+ EXPECT_EQ([findBarView frame].origin.y, 0);
EXPECT_TRUE([controller_ isFindBarVisible]);
- [controller_ hideFindBar];
- EXPECT_TRUE([findBarView isHidden]);
+ [controller_ hideFindBar:NO];
+ EXPECT_GT([findBarView frame].origin.y, 0);
EXPECT_FALSE([controller_ isFindBarVisible]);
}
TEST_F(FindBarCocoaControllerTest, SetFindText) {
- NSView* findBarView = [controller_ view];
NSTextField* findText = [controller_ findText];
// Start by making the find bar visible.
- [controller_ showFindBar];
- EXPECT_FALSE([findBarView isHidden]);
+ [controller_ showFindBar:NO];
+ EXPECT_TRUE([controller_ isFindBarVisible]);
// Set the find text.
const std::string kFindText = "Google";

Powered by Google App Engine
This is Rietveld 408576698