Issue 195102: Fix ARM build (gcc 3.3 failed to resolve types correctly) and constants names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195102: Fix ARM build (gcc 3.3 failed to resolve types correctly) and constants names. (Closed)

Created:
11 years, 3 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, sgjesse

CC:
v8-dev

Visibility:
Public.

Description

Fix ARM build (gcc 3.3 failed to resolve types correctly) and constants names. TBR=sgjesse@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=2904

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
	M	src/heap-profiler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	M	src/heap-profiler.cc	View		6 chunks	+9 lines, -8 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 3 months ago (2009-09-16 15:04:07 UTC) #2

LGTM

Thanks for fixing the build bustage so quickly.

http://codereview.chromium.org/195102/diff/1/2
File src/heap-profiler.cc (right):

http://codereview.chromium.org/195102/diff/1/2#newcode343
Line 343: ReferencesExtractor extractor(
This can be one line now.

Expand Messages | Collapse Messages