Issue 195101: X64: Ensure that unary subtraction returns a zero-extended smi, if it returns...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195101: X64: Ensure that unary subtraction returns a zero-extended smi, if it returns... (Closed)

Created:
11 years, 3 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Ensure that unary subtraction returns a zero-extended smi, if it returns a smi. Committed: http://code.google.com/p/v8/source/detail?r=2900

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/x64/codegen-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/mjsunit/array-splice.js	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

11 years, 3 months ago (2009-09-16 11:29:24 UTC) #2

LGTM

http://codereview.chromium.org/195101/diff/1002/2002
File test/mjsunit/array-splice.js (right):

http://codereview.chromium.org/195101/diff/1002/2002#newcode313
Line 313: // Test http://code.google.com/p/chromium/issues/detail?id=21860
We typically put these in test/mjsunit/regress/regress-<issue#>.js

Expand Messages | Collapse Messages