Issue 195098: sync-webkit-git: link to wiki, do some of Tony's review comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195098: sync-webkit-git: link to wiki, do some of Tony's review comments (Closed)

Created:
11 years, 3 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

sync-webkit-git: link to wiki, do some of Tony's review comments I had committed before I got Tony's feedback. This change does some of his suggestions and migrates some info to the wiki.

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -18 lines)			Patch
	M	tools/sync-webkit-git.py	View		4 chunks	+13 lines, -18 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 3 months ago (2009-09-15 22:42:50 UTC) #2

LGTM

http://codereview.chromium.org/195098/diff/1/2
File tools/sync-webkit-git.py (right):

http://codereview.chromium.org/195098/diff/1/2#newcode66
Line 66: print "third_party/WebKit has some other branch ('%s') checked out." %
branch
Nit: 80 cols.

Expand Messages | Collapse Messages